-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jobs: add pct job details struct #194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! I'm working on other stuff before I get PCT fully leveled, so I won't be able to test this for a bit either. But the struct looks right to me.
Minor formatting/prop change requested, and a purely optional stylistic suggestion (take it or leave it as you see fit).
Co-authored-by: Wexx <86693821+wexxlee@users.noreply.github.com>
Didn't test, i don't know about OP.... --------- Co-authored-by: Wexx <86693821+wexxlee@users.noreply.github.com> 4aba68f
Didn't test, i don't know about OP....
EDIT: I try be best, created a PR at the OP side: OverlayPlugin/OverlayPlugin#372